fix: update monospace font-face for fenced code block#910
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
this is all i had time to do right now - will check CI in a bit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #910 +/- ##
=======================================
Coverage 86.17% 86.17%
=======================================
Files 188 188
Lines 17146 17146
Branches 1540 1539 -1
=======================================
Hits 14776 14776
Misses 2363 2363
Partials 7 7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 1.28 s | 1.37 s | +90.00 ms (+7.03%) |
| User CPU time | 2.75 s | 2.87 s | +120.00 ms (+4.36%) |
| System CPU time | 340.00 ms | 330.00 ms | -10.00 ms (-2.94%) |
| Peak resident memory | 348.51 MB | 345.77 MB | -2.75 MB (-0.79%) |
legacy-html Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 12.46 s | 18.20 s | +5.74 s (+46.07%) |
| User CPU time | 39.93 s | 60.94 s | +21.01 s (+52.62%) |
| System CPU time | 1.60 s | 2.56 s | +960.00 ms (+60.00%) |
| Peak resident memory | 2.33 GB | 2.22 GB | -112.64 MB (-4.73%) |
legacy-json Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 10.23 s | 8.73 s | -1.50 s (-14.66%) |
| User CPU time | 27.83 s | 27.00 s | -830.00 ms (-2.98%) |
| System CPU time | 2.06 s | 1.91 s | -150.00 ms (-7.28%) |
| Peak resident memory | 1.69 GB | 1.67 GB | -26.36 MB (-1.52%) |
llms-txt Generator
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 7.74 s | 5.25 s | -2.49 s (-32.17%) |
| User CPU time | 23.79 s | 15.53 s | -8.26 s (-34.72%) |
| System CPU time | 1.32 s | 1.21 s | -110.00 ms (-8.33%) |
| Peak resident memory | 1.57 GB | 1.85 GB | +290.93 MB (+18.10%) |
orama-db Generator
Output size
| File | Base | Head | Diff |
|-|-|-|-|
| orama-db.json | 8.90 MB | 8.90 MB | -1.00 B (-0.00%) |
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 8.38 s | 8.76 s | +380.00 ms (+4.53%) |
| User CPU time | 23.44 s | 26.47 s | +3.03 s (+12.93%) |
| System CPU time | 1.44 s | 1.97 s | +530.00 ms (+36.81%) |
| Peak resident memory | 1.59 GB | 1.76 GB | +167.56 MB (+10.28%) |
web Generator
Output size
| File | Base | Head | Diff |
|-|-|-|-|
| all.html | 21.27 MB | 21.27 MB | -158.00 B (-0.00%) |
| styles.css | 141.88 KB | 141.99 KB | +106.00 B (+0.07%) |
Performance
| Metric | Base | Head | Diff |
|---|---|---|---|
| Elapsed time | 77.88 s | 77.17 s | -710.00 ms (-0.91%) |
| User CPU time | 161.49 s | 170.11 s | +8.62 s (+5.34%) |
| System CPU time | 4.90 s | 4.62 s | -280.00 ms (-5.71%) |
| Peak resident memory | 5.59 GB | 5.75 GB | +158.13 MB (+2.76%) |
PR SummaryLow Risk Overview Inside Reviewed by Cursor Bugbot for commit a2f9108. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Is this a doc-kit specific issue, or should this fix be upstreamed to |
|
https://api-docs-tooling-git-windows-table-openjs.vercel.app/url.html looks good on my WIndows 25H2 system as well. |
|
Is "font-sace" a typo? Perhaps "font-space" or "font-face" is meant? |
I can check today by recreating the table in some website about markdown. |
Description
Adds a font-stack for pre / code blocks.
I heavily used Claude Code Opus to measure glphs and understand the problem, the fix is quite easy and surgical, suggested by me.
Validation
Watch the preview
https://api-docs-tooling-git-windows-table-openjs.vercel.app/url.html
Related Issues
Possible fix for #909
Check List
node --run testand all tests passed.node --run format&node --run lint.