Skip to content

Update Node 10 Alpine version#999

Closed
mastersingh24 wants to merge 1 commit into
nodejs:masterfrom
mastersingh24:alpine3.9
Closed

Update Node 10 Alpine version#999
mastersingh24 wants to merge 1 commit into
nodejs:masterfrom
mastersingh24:alpine3.9

Conversation

@mastersingh24

Copy link
Copy Markdown

Closes #998

Given Node 10 is the current LTS, it makes sense to move to Alpine 3.9. Node 11 images are already using 3.9 as well.

Update from 3.8 to 3.9

Signed-off-by: Gari Singh <gari.r.singh@gmail.com>
@SimenB

SimenB commented Feb 23, 2019

Copy link
Copy Markdown
Member

We can merge this after the upcoming security release, I think.

/cc @nodejs/docker

@LaurentGoderre

Copy link
Copy Markdown
Member

@SimenB we usually wait for a new Node version to avoid breaking builds etc.

@SimenB

SimenB commented Feb 24, 2019

Copy link
Copy Markdown
Member

I know, but I don't think an OS upgrade should be bundled with a security update

@LaurentGoderre

Copy link
Copy Markdown
Member

@SimenB yeah, I think it should be the one after the security update?

@PeterDaveHello PeterDaveHello left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we will deliver that with a regular release?

@JCMais

JCMais commented Mar 12, 2019

Copy link
Copy Markdown

fyi we had some failed builds today because of this change, some native add-ons we use failed building and some apk dependencies were not found after upgrading to v10.15.3 because of the Alpine version bump.

@mahulst

mahulst commented Mar 21, 2019

Copy link
Copy Markdown

We've had some issues with curl and SSL since this release.
Error was curl: (35) OpenSSL SSL_connect: SSL_ERROR_SYSCALL in connection to <domain>
We've reverted back to 10.15.2-alpine which resolves it for now.

@PeterDaveHello

Copy link
Copy Markdown
Member

cc @nodejs/docker ⬆️

@LaurentGoderre

Copy link
Copy Markdown
Member

Would that be because of the new version of Alpine?

@JCMais

JCMais commented Mar 21, 2019

Copy link
Copy Markdown

@LaurentGoderre most probably, yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants