This repository was archived by the owner on Oct 15, 2020. It is now read-only.
master branch cleanup#466
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
I'll rebase this on #465 once that lands. |
digitalinfinity
approved these changes
Feb 14, 2018
Contributor
Author
kfarnung
force-pushed
the
cleanup
branch
3 times, most recently
from
February 16, 2018 02:10
6e6e6bf to
0989d78
Compare
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 16, 2018
* Fixed differences with upstream in the `src/` folder * Fixed linux test failure in `test-cli-node-options.js` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 16, 2018
* Moved `unordered_set` to `v8-tracing.h` to match v8 * Fixed `int64`->`double` implicit cast in `v8-platform.h` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
* Fixed differences with upstream in the `src/` folder * Fixed linux test failure in `test-cli-node-options.js` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
* Moved `unordered_set` to `v8-tracing.h` to match v8 * Fixed `int64`->`double` implicit cast in `v8-platform.h` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Feb 23, 2018
* Moved `unordered_set` to `v8-tracing.h` to match v8 * Fixed `int64`->`double` implicit cast in `v8-platform.h` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 6, 2018
* Moved `unordered_set` to `v8-tracing.h` to match v8 * Fixed `int64`->`double` implicit cast in `v8-platform.h` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
kfarnung
added a commit
to kfarnung/node-chakracore
that referenced
this pull request
Mar 7, 2018
* Moved `unordered_set` to `v8-tracing.h` to match v8 * Fixed `int64`->`double` implicit cast in `v8-platform.h` PR-URL: nodejs#466 Reviewed-By: Taylor Woll <tawoll@ntdev.microsoft.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
chakrashim, src, test