This repository was archived by the owner on Oct 15, 2020. It is now read-only.
deps: allow openssl to build for WOA#515
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
|
New CI for vcbuild change: https://ci.nodejs.org/job/chakracore-test/312/ |
Contributor
|
Is this my change more or less verbatim or are there particular changes you'd like me to review? If not, LGTM 😄 |
Contributor
Author
|
It's just your change with the patch for vcbuild.bat. I believe the build machines in the CI have NASM installed so it again went down the Linux path. |
Contributor
Author
|
Looks like the ARM build is good now: https://ci.nodejs.org/job/node-compile-windows/17473/label=win-vs2017-arm/ |
Contributor
|
Ah lol! I wondered about that but assumed that the config script would have automatically switched to using the asm disabled version. Ok, LGTM- thanks for adopting! |
MSLaguana
approved these changes
Apr 18, 2018
* Add definitions to enable building for Windows on ARM * Disable ASM for Windows on ARM builds PR-URL: nodejs#515 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 18, 2018
* Add definitions to enable building for Windows on ARM * Disable ASM for Windows on ARM builds PR-URL: nodejs#515 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
kfarnung
pushed a commit
to kfarnung/node-chakracore
that referenced
this pull request
Apr 18, 2018
* Add definitions to enable building for Windows on ARM * Disable ASM for Windows on ARM builds PR-URL: nodejs#515 Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add definitions to enable building for Windows on ARM
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes