Skip to content

lib: support BigInt in querystring.stringify#36499

Closed
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/add-BigInt-support-for-querystring.stringify
Closed

lib: support BigInt in querystring.stringify#36499
RaisinTen wants to merge 1 commit into
nodejs:masterfrom
RaisinTen:lib/add-BigInt-support-for-querystring.stringify

Conversation

@RaisinTen

@RaisinTen RaisinTen commented Dec 13, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #36080

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the querystring Issues and PRs related to the built-in querystring module. label Dec 13, 2020
addaleax
addaleax reviewed Dec 13, 2020
View reviewed changes
Comment thread lib/querystring.js Outdated
@RaisinTen
RaisinTen force-pushed the lib/add-BigInt-support-for-querystring.stringify branch from 93c6119 to 443794e Compare December 13, 2020 15:38
@RaisinTen
RaisinTen marked this pull request as ready for review December 13, 2020 15:38
@mscdex

mscdex commented Dec 13, 2020

Copy link
Copy Markdown
Contributor

Shouldn't stringifyPrimitive() be updated and tested as well?

@RaisinTen
RaisinTen force-pushed the lib/add-BigInt-support-for-querystring.stringify branch from 443794e to 52367cf Compare December 14, 2020 12:09
@RaisinTen
RaisinTen force-pushed the lib/add-BigInt-support-for-querystring.stringify branch from 52367cf to 4079821 Compare December 14, 2020 12:16
@RaisinTen

RaisinTen commented Dec 14, 2020

Copy link
Copy Markdown
Member Author

Done, PTAL. :)

joyeecheung
joyeecheung reviewed Dec 14, 2020
View reviewed changes
Comment thread lib/querystring.js
@PoojaDurgad PoojaDurgad added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 17, 2020
@nodejs-github-bot

nodejs-github-bot commented Dec 17, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34987/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2020
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 21, 2020
@targos

targos commented Dec 21, 2020

Copy link
Copy Markdown
Member

Landed in 1eb228e

@targos targos closed this Dec 21, 2020
targos pushed a commit that referenced this pull request Dec 21, 2020
@RaisinTen @targos
lib: support BigInt in querystring.stringify
1eb228e 
Fixes: #36080

PR-URL: #36499
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@RaisinTen
RaisinTen deleted the lib/add-BigInt-support-for-querystring.stringify branch December 21, 2020 14:08
targos pushed a commit that referenced this pull request Dec 21, 2020
@RaisinTen @targos
lib: support BigInt in querystring.stringify
5481be8 
Fixes: #36080

PR-URL: #36499
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos added a commit that referenced this pull request Dec 22, 2020
@targos
2020-12-22, Version 15.5.0 (Current)
eb84150 
Notable changes:

    child_process:
      * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432
    doc:
      * add PoojaDurgad to collaborators (Pooja D P) #36511
    lib:
      * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499
    src:
      * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441
      * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447
    stream:
      * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431

PR-URL: #36597
targos added a commit that referenced this pull request Dec 22, 2020
@targos
2020-12-22, Version 15.5.0 (Current)
f978628 
Notable changes:

    child_process:
      * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432
    doc:
      * add PoojaDurgad to collaborators (Pooja D P) #36511
    lib:
      * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499
    src:
      * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441
      * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447
    stream:
      * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431

PR-URL: #36597
targos added a commit that referenced this pull request Dec 22, 2020
@targos
2020-12-22, Version 15.5.0 (Current)
80d2fbe 
Notable changes:

    child_process:
      * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) #36432
    doc:
      * add PoojaDurgad to collaborators (Pooja D P) #36511
    lib:
      * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) #36499
    src:
      * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) #36441
      * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) #36447
    stream:
      * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) #36431

PR-URL: #36597
targos pushed a commit that referenced this pull request May 1, 2021
@RaisinTen @targos
lib: support BigInt in querystring.stringify
3ee0423 
Fixes: #36080

PR-URL: #36499
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@hkleungai hkleungai mentioned this pull request Apr 26, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax left review comments
@joyeecheung joyeecheung joyeecheung left review comments
@targos targos targos approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. querystring Issues and PRs related to the built-in querystring module. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

querystring.stringify does not support BigInt

8 participants

@RaisinTen @mscdex @nodejs-github-bot @targos @addaleax @joyeecheung @aduh95 @PoojaDurgad