Skip to content

build: extract temporal_capi crate directory name into gyp variable#64482

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:crates-gyp-include-path
Jul 16, 2026
Merged

build: extract temporal_capi crate directory name into gyp variable#64482
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
Renegade334:crates-gyp-include-path

Conversation

@Renegade334

@Renegade334 Renegade334 commented Jul 14, 2026

Copy link
Copy Markdown
Member

This is a no-op for current builds, but will allow the crate updater (nodejs/node-core-utils#1117) to update the include path with the new crate location, as the crate directory names will include a version string.

This is a no-op for current builds, but will allow the crate updater in
node-core-utils to update the include path with the new crate location,
as the crate directory names will include a version string.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@Renegade334 Renegade334 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jul 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Jul 14, 2026
@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 14, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 14, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 16, 2026
@nodejs-github-bot nodejs-github-bot merged commit f2ba101 into nodejs:main Jul 16, 2026
79 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in f2ba101

@Renegade334 Renegade334 deleted the crates-gyp-include-path branch July 16, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants