CLD-559: paginate list_hosted_zones in snapshot list Lambda#17
Open
johnnally wants to merge 1 commit into
Open
CLD-559: paginate list_hosted_zones in snapshot list Lambda#17johnnally wants to merge 1 commit into
johnnally wants to merge 1 commit into
Conversation
Accounts with more than 100 hosted zones were only having the first 100 returned when a tagged zone triggered a single-zone snapshot. If the new zone was not in that first page, the filter found no match and silently fell through to snapshot all 100 zones instead — causing unrelated zones to be snapshotted and the intended zone to never sync to NS1. Fixed by replacing the single list_hosted_zones() call with a paginator that collects all zones before filtering. Also hardened the filter to raise explicitly if the target zone is not found, rather than falling through silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accounts with more than 100 hosted zones were only having the first 100 returned when a tagged zone triggered a single-zone snapshot. If the new zone was not in that first page, the filter found no match and silently fell through to snapshot all 100 zones instead — causing unrelated zones to be snapshotted and the intended zone to never sync to NS1.
Fixed by replacing the single list_hosted_zones() call with a paginator that collects all zones before filtering. Also hardened the filter to raise explicitly if the target zone is not found, rather than falling through silently.