🌍 #349 Improve integer generator run performance by 30-35%#354
Merged
Conversation
We cache the work when we create an int gen, but inside a SelectMany, we're creating a new gen every iteration. Lazily calculate the bounds ranges. Before: ``` | Method | Mean | Error | StdDev | |---------------------- |----------:|----------:|----------:| | SelectManyGen | 31.904 us | 0.5425 us | 0.8120 us | | SelectManyGenBaseline | 9.950 us | 0.1692 us | 0.1500 us | ``` After: ``` | Method | Mean | Error | StdDev | |---------------------- |----------:|----------:|----------:| | SelectManyGen | 20.077 us | 0.3833 us | 0.4101 us | | SelectManyGenBaseline | 9.833 us | 0.1924 us | 0.2363 us | ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cache the work when we create an int gen, but inside a SelectMany, we're creating a new gen every iteration.
Lazily calculate the bounds ranges.
Before:
After: