🌍 #343 Enable generating nullable types by reflection#359
Merged
Conversation
What a mission nullability reflection in C# is. We now reflect types augmented with the `?` syntax, and pass them through to `Gen.Nullable`. This includes properties, fields and parameters (including constructor arguments, like when we generate records). Syntax like `Gen.Create<string?>` does not capture the nullability context, so it's impossible to generate nulls for these. However, most likely the entrypoint to generation will be a method parameter (when writing properties), so consumers will likely be unaffected. I've added a `where T : notnull` constraint to these methods now, not that it is strictly required, but will prompt users down the right path if they run into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a mission nullability reflection in C# is.
We now reflect types augmented with the
?syntax, and pass them through toGen.Nullable. This includes properties, fields and parameters (including constructor arguments, like when we generate records).Syntax like
Gen.Create<string?>does not capture the nullability context, so it's impossible to generate nulls for these. However, most likely the entrypoint to generation will be a method parameter (when writing properties), so consumers will likely be unaffected. I've added awhere T : notnullconstraint to these methods now, not that it is strictly required, but will prompt users down the right path if they run into it.