🌍 #371 Fix infinite rendering loop on static properties#381
Merged
Conversation
nth-commit
force-pushed
the
terra/fix-infinite-rendering-loop
branch
from
May 25, 2023 01:13
ea1e55e to
4e84e48
Compare
It's not meaningful to render static properties on a (non-static) counterexample, so don't. Also, this was causing an infinite loop when rendering a counterexample containing System.Drawing.Color. I've put in an extra safeguard, so that the object renderer checks that it isn't rendering a type that it hasn't just seen.
nth-commit
force-pushed
the
terra/fix-infinite-rendering-loop
branch
from
May 25, 2023 01:27
4e84e48 to
80cac82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not meaningful to render static properties on a (non-static) counterexample, so don't.
Also, this was causing an infinite loop when rendering a counterexample containing System.Drawing.Color. I've put in an extra safeguard, so that the object renderer checks that it isn't rendering a type that it hasn't just seen.