Remove cross-fetch dependency in favor of global fetch

[Copilot]

Supercedes #124. Note this is a breaking change since Node 18 will be the minimum node version supported after this change. This is not an issue since the current maintenance version of node is Node 20.

fetch is globally available since Node 18, which is now the minimum supported version. Remove the cross-fetch polyfill across the monorepo.

• Source files: Remove cross-fetch imports from guaranteeFetch.ts, authFetch.ts, UnauthenticatedSolidLdoProvider.tsx, and test helpers in solid-type-index and solid-react — all now use the global fetch
• Package dependencies: Remove cross-fetch from dependencies/devDependencies in connected-solid, ldo, react, connected-nextgraph, and solid-react

// Before
import crossFetch from "cross-fetch";
export function guaranteeFetch(fetchInput?: typeof fetch): typeof fetch {
  return fetchInput || crossFetch;
}

// After
export function guaranteeFetch(fetchInput?: typeof fetch): typeof fetch {
  return fetchInput || fetch;
}

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Remove cross-fetch usage</issue_title>
<issue_description>fetch is a global object as of Node 18; which is now the oldest supported version of Node. Thus it is safe to remove the cross-fetch global and just use fetch in the next major release.</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Remove cross-fetch usage #99

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[jeswr]

Supercedes #124

[Copilot]

Pull request overview

This PR removes the cross-fetch polyfill across the monorepo and switches all internal usage to the global fetch now that Node 18+ is assumed.

Changes:

• Replace cross-fetch imports/usages with the global fetch in runtime code and test helpers.
• Update guaranteeFetch and its test to default to global fetch.
• Remove cross-fetch from package dependencies/devDependencies and update the workspace lockfile.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/test-solid-server/src/authFetch.ts	Drops cross-fetch import; relies on global fetch for auth flow requests.
packages/solid-type-index/test/fileData.ts	Removes cross-fetch type import; uses global fetch typing for helpers.
packages/solid-react/test/fileData.ts	Removes cross-fetch import; uses global fetch in test setup.
packages/solid-react/src/UnauthenticatedSolidLdoProvider.tsx	Replaces cross-fetch with global fetch in auth context provider.
packages/solid-react/package.json	Removes direct cross-fetch dependency.
packages/react/package.json	Removes direct cross-fetch dependency.
packages/ldo/package.json	Removes direct cross-fetch devDependency.
packages/connected-solid/test/guaranteeFetch.test.ts	Updates expectation to default to global fetch.
packages/connected-solid/src/util/guaranteeFetch.ts	Updates implementation/docs to default to global fetch.
packages/connected-solid/package.json	Removes direct cross-fetch dependency.
packages/connected-nextgraph/package.json	Removes direct cross-fetch dependency.
package-lock.json	Reflects dependency graph changes after removing direct cross-fetch deps.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mrkvon]

I rebased this with main and resolved conflicts. Also replaced outstanding cross-fetch introduced later. Let's try to get this PR resolved.

I also added DOM to tsconfig lib array to make up for missing polyfills. It seems like cross-fetch had previously brought DOM types with it, and removing it caused a pile of new type errors.

Note: Adding DOM to global tsconfig is suboptimal. Most of the LDO packages can be used in non-browser environments. Adding DOM to these packages can be misleading as it includes unsupported types. This can be improved, but requires deep restructuring of tsconfig.json across the monorepo. Possible follow-up.

[jeswr]

LGTM - thanks for doing the work @mrkvon

cc @jaxoncreed

[jaxoncreed]

LGTM