[WIP] Fix dependencies - #160
Draft
mrkvon wants to merge 7 commits into
Draft
Conversation
npx create-next-app@latest solid-react-nextjs-app
Make sure client-only API (SharedWorker) doesn't run on server. Add "use client" directive. Test this with the new example nextjs app.. Fixes o-development#153
+ Add a README explaining dev directory's purpose. + Remove distracting styles + Update favicon
Also, add other files from the default Vite + React + TS app generated with `npm create vite@latest`
Explicitly resolve @types/react to local node_modules. List react as peerDependency of @ldo/solid-react.
With knip npx knip npx knip --production npx knip --strict
using `npx knip` to detect issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using knip to detect issues in dependencies and devDependencies, like unused or unlisted packages.
Work in progress. A lot of issues detected.
This PR is on top of #156, which should be merged first, then this should be rebased.