Skip to content

feat: support Tempo Query V2 and search tag values endpoint in trace RBAC#916

Open
andreasgerstmayr wants to merge 3 commits into
observatorium:mainfrom
andreasgerstmayr:tempo-query-v2
Open

feat: support Tempo Query V2 and search tag values endpoint in trace RBAC#916
andreasgerstmayr wants to merge 3 commits into
observatorium:mainfrom
andreasgerstmayr:tempo-query-v2

Conversation

@andreasgerstmayr

@andreasgerstmayr andreasgerstmayr commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Support the following Tempo APIs with trace RBAC:

  • /api/v2/traces/<traceid>
  • /api/v2/search/tag/(resource\.service\.name|resource\.k8s\.namespace\.name)/values

pavolloffay
pavolloffay previously approved these changes Jul 23, 2026
View reviewed changes
Comment thread api/traces/v1/trace_rbac.go

responseBuffer := &bytes.Buffer{}
if strings.HasPrefix(response.Request.URL.Path, "/api/traces/") {
switch {

@pavolloffay pavolloffay Jul 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add a default case with some logging?

@andreasgerstmayr andreasgerstmayr Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@andreasgerstmayr
add warning in default case
b1e85f6 
Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr

andreasgerstmayr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author 
2026-07-23T11:56:28.2313772Z     --- FAIL: TestWithLocalRateLimiter/one_rate_limiter (0.01s)

Fails, which is unrelated. Please restart CI

@andreasgerstmayr

andreasgerstmayr commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Now it fails with

=== NAME  TestLogs/read-write
    logs_test.go:64: logs_test.go:64: ""
        
         unexpected error: unable to find metrics [http_requests_total] with expected values after 50 retries. Last error: <nil>. Last values: [23]

again, unrelated 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pavolloffay pavolloffay pavolloffay left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreasgerstmayr @pavolloffay