Skip to content

fix: incorrect passing of Thread instance to Store.save_thread - #9

Merged
weedon-openai merged 2 commits into
openai:mainfrom
quettabit:qb/save-thread-meta
Oct 10, 2025
Merged

fix: incorrect passing of Thread instance to Store.save_thread #9
weedon-openai merged 2 commits into
openai:mainfrom
quettabit:qb/save-thread-meta

Conversation

@quettabit

@quettabit quettabit commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

as Thread is passed to save_thread and given it already has items field, it leads to the following runtime error on the read path:

TypeError: chatkit.types.Thread() got multiple values for keyword argument 'items'

and it happens at:

return Thread(**thread_meta.model_dump(), items=thread_items)

@quettabit
quettabit marked this pull request as ready for review October 7, 2025 09:25
@quettabit quettabit changed the title fix incorrect passing of Thread instance to Store.save_thread fix: incorrect passing of Thread instance to Store.save_thread Oct 7, 2025
@quettabit

Copy link
Copy Markdown
Contributor Author

@jiwon-oai @victor-openai just bumping this one!

@jiwon-oai jiwon-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m - we're still working on getting some processes set up for this repo though, thanks for your patience!

@weedon-openai
weedon-openai added this pull request to the merge queue Oct 10, 2025
Merged via the queue into openai:main with commit 8e2d257 Oct 10, 2025
1 check passed
@openai openai deleted a comment from BleuS0sa Oct 15, 2025

@BleuS0sa BleuS0sa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants