fix: add display_number and display_org to v4 home test expected data - #38935
Merged
Conversation
Commit d83c598 added display_number and display_org to CourseCommonSerializerV2 (which CourseHomeTabSerializerV4 aliases), but only updated the v2 test. The v4 test_home_page_response was left expecting the old 10-field format and now fails.
feanil
force-pushed
the
feanil/fix-v4-home-test-display-fields
branch
from
July 30, 2026 13:34
632ea80 to
4745295
Compare
feanil
marked this pull request as ready for review
July 30, 2026 13:37
Contributor
Author
|
@Faraz32123 it looks like the merge of the BIG api PR had some interactions with some other changes and so some tests started failing. Using this PR to fix the issues so we can get master back to green. |
Faraz32123
approved these changes
Jul 30, 2026
Faraz32123
left a comment
Faraz32123
left a comment
Contributor
There was a problem hiding this comment.
Changes Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
display_numberanddisplay_orgtoCourseCommonSerializerV2(whichCourseHomeTabSerializerV4aliases), but only updated the v2 test.TestHomeCoursesViewSet.test_home_page_responsein v4, but without those two fields in the expected data.cms-2CI fails with a dict mismatch ontest_home_page_response.This one-line fix adds the missing fields to the v4 test's expected
OrderedDict, matching the serializer's field order.