Remove unused edisgo/tools/powermodels_io.py#707
Open
jldonner wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove the unused legacy PowerModels converter from
edisgo/tools/powermodels_io.py.The active OPF converter remains in
edisgo/io/powermodels_io.py.The legacy converter is not imported by the code base and contains
conversion logic and storage-efficiency values that differ from the
active OPF implementation. Keeping it makes investigations of the OPF
pipeline unnecessarily confusing.
Type of change
edisgo/tools/powermodels_io.pyedisgo.tools.powermodels_ioremainCloses #699
Checklist:
pre-commithooks