STOR-2297: remove oVirt from ClusterCSIDriver API

[RomanBednar]

No description provided.

[openshift-ci-robot]

@RomanBednar: This pull request references STOR-2297 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @RomanBednar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[JoelSpeed]

@RomanBednar When did ovirt support get removed from OCP?

[RomanBednar]

@RomanBednar When did ovirt support get removed from OCP?

@JoelSpeed in 4.14

https://docs.openshift.com/container-platform/4.14/release_notes/ocp-4-14-release-notes.html#ocp-4-14-rhv-deprecations

[RomanBednar]

/hold

This should be changed - instead of removal we should just add a comment about the deprecation.

[JoelSpeed]

If we haven't supported oVirt since 4.14 (2 years ago), then we aren't supporting anyone upgrading to 4.21 on oVirt, so at this point, I suspect we can remove the value without breaking anyone

[RomanBednar]

/unhold

@JoelSpeed We've discussed this a bit more and agreed that removal is fine. Is the current PR ok for this, assuming we can override the verify jobs? Seems like there are comparators to protect against accidental removals. Or do we need something different and pass the jobs?

[JoelSpeed]

/lgtm
/override ci/prow/verify-crd-schema ci/prow/verify-crdify

We haven't supported ovirt for many releases, so removing these should be fine

[openshift-ci-robot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/lgtm
/override ci/prow/verify-crd-schema ci/prow/verify-crdify

We haven't supported ovirt for many releases, so removing these should be fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[RomanBednar]

ping @openshift/storage-qe for verification

[Phaow]

/verified by @Phaow
We haven't supported ovirt for many releases, installer already remove the install support for it many releases, the clean up looks good.

[openshift-ci-robot]

@Phaow: This PR has been marked as verified by @Phaow.

Details

In response to this:

/verified by @Phaow
We haven't supported ovirt for many releases, installer already remove the install support for it many releases, the clean up looks good.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD d13e8c6 and 2 for PR HEAD 3a83ba5 in total

[JoelSpeed]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a50fd9f and 1 for PR HEAD 3a83ba5 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 627ea21 and 0 for PR HEAD 3a83ba5 in total

[openshift-ci-robot]

/hold

Revision 3a83ba5 was retested 3 times: holding

[RomanBednar]

/unhold

[JoelSpeed]

/override ci/prow/verify-crdify
/override ci/prow/verify-crd-schema

These will not pass on this PR

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/override ci/prow/verify-crdify
/override ci/prow/verify-crd-schema

These will not pass on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 621beb4 and 2 for PR HEAD 3a83ba5 in total

[openshift-ci]

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.