Skip to content

MCO-1736: Promote ImageModeStatusReporting feature gate to default#2738

Draft
isabella-janssen wants to merge 1 commit into
openshift:masterfrom
isabella-janssen:mco-1736
Draft

MCO-1736: Promote ImageModeStatusReporting feature gate to default#2738
isabella-janssen wants to merge 1 commit into
openshift:masterfrom
isabella-janssen:mco-1736

Conversation

@isabella-janssen

Copy link
Copy Markdown
Member

Opening as a draft to monitor component readiness score.

@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown

@isabella-janssen: This pull request references MCO-1736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Opening as a draft to monitor component readiness score.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Mar 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6b162142-b3c8-4018-9a46-24ff563f3745

📥 Commits

Reviewing files that changed from the base of the PR and between 72066cc and 28becb2.

📒 Files selected for processing (6)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

📝 Walkthrough

Walkthrough

ImageModeStatusReporting is enabled for default and OKD environments in the feature-gate definition. The feature matrix marks it enabled across all listed contexts. HyperShift and SelfManagedHA default and OKD release manifests remove it from disabled gates and add it to enabled gates.

Suggested reviewers: sadasu, vr4manta, davidesalerno

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: promoting ImageModeStatusReporting to default.
Description check ✅ Passed The description is related to the PR context and mentions the draft/readiness monitoring purpose.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No Ginkgo test titles were added or modified; the PR only changes feature-gate config, docs, and manifests.
Test Structure And Quality ✅ Passed No Ginkgo test code was changed; the PR only updates feature-gate docs/manifests and a feature registration, so test-structure checks don’t apply.
Microshift Test Compatibility ✅ Passed No Ginkgo/e2e test files were added or modified; the PR only updates feature-gate docs and manifests.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Diff only changes feature-gate docs/config; no new Ginkgo tests or e2e/test paths were added, so there are no SNO-specific assumptions to review.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: Diff only promotes ImageModeStatusReporting in feature-gate metadata/docs; no pod specs, affinities, nodeSelectors, or topology-based replica logic changed.
Ote Binary Stdout Contract ✅ Passed Touched files are docs/YAML plus feature declarations; no main/init/TestMain/suite setup stdout writes or stdout logging were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only feature metadata/manifests changed; no new Ginkgo e2e tests or network connectivity code was added.
No-Weak-Crypto ✅ Passed Touched files only toggle ImageModeStatusReporting feature-gate metadata; no MD5/SHA1/DES/RC4/3DES/Blowfish, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed Diff only promotes ImageModeStatusReporting in feature-gate tables; no privileged:true, host* flags, SYS_ADMIN, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs ✅ Passed The PR only flips ImageModeStatusReporting feature-gate enablement in docs, Go config, and YAML; no logging code or sensitive-data fields were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'

  • 1 others
🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2026
@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2026
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 3, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@openshift-ci

openshift-ci Bot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 5, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 5, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 12, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Mar 12, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 25, 2026
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

2 similar comments
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@everettraven

Copy link
Copy Markdown
Contributor

/testwith openshift/api/master/verify-feature-promotion #2782

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

5 similar comments
@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@yuqi-zhang

Copy link
Copy Markdown
Contributor

/testwith openshift/api/master/verify-feature-promotion #2789

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Apr 2, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@qodo-code-review

qodo-code-review Bot commented Apr 7, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
Member Author

/test verify-feature-promotion

@openshift-ci openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2026
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-feature-promotion 28becb2 link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants