Skip to content

CNTRLPLANE-3609: graduate etcdBackendQuota to GA #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dusk125 wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −16
Open

CNTRLPLANE-3609: graduate etcdBackendQuota to GA #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
| ConfigurablePKI| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DNSNameResolver| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DyanmicServiceEndpointIBMCloud| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EtcdBackendQuota| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| Example| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDCExternalClaimsSourcing| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDCWithUpstreamParity| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down Expand Up @@ -103,6 +102,7 @@
| BuildCSIVolumes| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| DualReplica| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EVPN| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EtcdBackendQuota| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| EventTTL| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDC| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDCWithUIDAndExtraClaimMappings| <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
6 changes: 3 additions & 3 deletions features/features.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,8 @@ var (
reportProblemsToJiraComponent("etcd").
contactPerson("hasbro17").
productScope(ocpSpecific).
enhancementPR(legacyFeatureGateWithoutEnhancement).
enable(inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
enhancementPR("https://github.com/openshift/enhancements/pull/2031").
enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()).
Comment on lines +225 to +226

@qodo-for-rh-openshift qodo-for-rh-openshift Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No crds for tests 🐞 Bug ☼ Reliability

EtcdBackendQuota is now enabled for all shipped feature sets (Default/OKD/TechPreview/DevPreview),
but etcd API validation suites still require it disabled ("-EtcdBackendQuota"), causing the suite
loader to find zero matching CRD manifests and abort. This breaks
operator/v1/tests/etcds.operator.openshift.io/AAA_ungated.yaml and HardwareSpeed.yaml selection via
tests/crd_filter.go filtering logic.
Agent Prompt 
### Issue description
Etcd API validation suites for etcd still require `-EtcdBackendQuota`, but the PR enables `EtcdBackendQuota` in Default/OKD (and it is already enabled in DevPreview/TechPreview). The test generator filters CRDs based on payload featuregate enablement; after this PR there are no matching CRD manifests where the gate is disabled, so suite loading fails.

### Issue Context
- `AAA_ungated.yaml` and `HardwareSpeed.yaml` are currently pinned to run only when `EtcdBackendQuota` is disabled.
- After GA graduation, the gate is enabled everywhere; the tests should become ungated (remove the `featureGates` constraint) or be rewritten to target the correct (now-unconditional) schema.

### Fix Focus Areas
- operator/v1/tests/etcds.operator.openshift.io/AAA_ungated.yaml[2-18]
- operator/v1/tests/etcds.operator.openshift.io/HardwareSpeed.yaml[2-41]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

mustRegister()

FeatureGateAutomatedEtcdBackup = newFeatureGate("AutomatedEtcdBackup").
Expand Down Expand Up @@ -673,7 +673,7 @@ var (
enhancementPR("https://github.com/openshift/enhancements/pull/2033").
enable(inDevPreviewNoUpgrade(), inTechPreviewNoUpgrade()).
mustRegister()

FeatureGateIngressControllerMultipleHAProxyVersions = newFeatureGate("IngressControllerMultipleHAProxyVersions").
reportProblemsToJiraComponent("Networking/router").
contactPerson("miciah").
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventedPLEG"
},
Expand Down Expand Up @@ -322,6 +319,9 @@
{
"name": "EVPN"
},
{
"name": "EtcdBackendQuota"
},
Comment on lines +322 to +324

@qodo-for-rh-openshift qodo-for-rh-openshift Bot Jul 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

2. Crds not regenerated 🐞 Bug ≡ Correctness

The payload featuregate manifests now enable EtcdBackendQuota for Default/OKD, but the checked-in
generated etcd CRDs for those feature sets still omit spec.backendQuotaGiB, so the GA field is not
actually present in the Default/OKD structural schemas. This creates a mismatch where featuregate
configuration says the gate is enabled but the shipped CRD schema doesn’t include the gated field
(contrast with DevPreview/TechPreview CRDs which do include it).
Agent Prompt 
### Issue description
After enabling `EtcdBackendQuota` in Default/OKD feature sets, the generated CRD manifests for etcd in those feature sets must include the gated `spec.backendQuotaGiB` field (and its default/validation). The repo currently has Default/OKD etcd CRDs that still lack this field.

### Issue Context
- The DevPreviewNoUpgrade CRD already contains `backendQuotaGiB`, demonstrating the partial schema exists and merges when the gate is enabled.
- Default/OKD etcd CRD manifests should now match that schema inclusion.

### Fix Focus Areas
- operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-Default.crd.yaml[35-120]
- operator/v1/zz_generated.crd-manifests/0000_12_etcd_01_etcds-OKD.crd.yaml[1-120]
- payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml[291-340]
- payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml[315-334]
- features/features.go[221-227]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

{
"name": "EventTTL"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventedPLEG"
},
Expand Down Expand Up @@ -324,6 +321,9 @@
{
"name": "EVPN"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventTTL"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventedPLEG"
},
Expand Down Expand Up @@ -316,6 +313,9 @@
{
"name": "EVPN"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventTTL"
},
Expand Down
6 changes: 3 additions & 3 deletions payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,6 @@
{
"name": "DyanmicServiceEndpointIBMCloud"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventedPLEG"
},
Expand Down Expand Up @@ -318,6 +315,9 @@
{
"name": "EVPN"
},
{
"name": "EtcdBackendQuota"
},
{
"name": "EventTTL"
},
Expand Down