NO-JIRA: fix(pkg/cincinnati): log the correct root CA pool size

[vprashar2929]

GetUpdates checked TLSClientConfig.ClientCAs to decide whether to log the root CA subject count, but the client transport only ever populates RootCAs (ClientCAs is a server-side field, never set for this outbound client). The nil check was therefore always true: the log always reported "0 root CA subjects" and the branch reporting the real count was dead. Check RootCAs instead, which also correctly guards the RootCAs.Subjects() dereference in the else branch.

Summary by CodeRabbit

• Bug Fixes
  • Improved TLS certificate handling when fetching updates.
  • Fixed an issue where the app could inspect the wrong certificate pool, which affected root CA logging and could cause errors when no root CA list was set.

[openshift-ci]

Hi @vprashar2929. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Walkthrough

Client.GetUpdates now checks TLSClientConfig.RootCAs before logging and using the root CA subject list.

Changes

TLS root CA nil-check fix

Layer / File(s)	Summary
Root CA nil-check pkg/cincinnati/cincinnati.go	GetUpdates now tests TLSClientConfig.RootCAs == nil in the root CA branch before reading Subjects() and logging the subject count.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only pkg/cincinnati/cincinnati.go changed; it’s non-test code and pkg/cincinnati has no Ginkgo titles, so no unstable test names were introduced.
Test Structure And Quality	✅ Passed	No Ginkgo tests were changed or added here; pkg/cincinnati uses standard Go tests only, so the test-quality checklist is not applicable.
Microshift Test Compatibility	✅ Passed	PR only changes pkg/cincinnati/cincinnati.go in GetUpdates; no new Ginkgo test declarations or OpenShift API/resource uses were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only touches pkg/cincinnati/cincinnati.go; no new or modified Ginkgo e2e tests or SNO-sensitive cluster assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The PR only changes TLS root CA logging in pkg/cincinnati; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only changes a nil check in Client.GetUpdates; no main/init/TestMain/suite setup or stdout writes were added in the touched code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only changes pkg/cincinnati/cincinnati.go; no new Ginkgo e2e tests or network-facing test code were added.
No-Weak-Crypto	✅ Passed	Touched code only changes a RootCAs nil check for logging; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret comparisons found.
Container-Privileges	✅ Passed	The change is confined to pkg/cincinnati/cincinnati.go and only adjusts TLS CA logging; no container/K8s manifests or privilege settings are touched.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only changes a nil check in an existing log branch; it does not add or expand logging of secrets, PII, or internal data.
Title check	✅ Passed	The title clearly matches the main change: fixing root CA pool size logging in pkg/cincinnati.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[vprashar2929]

/ok-to-test

[openshift-ci]

@vprashar2929: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[DavidHurta]

/ok-to-test

[DavidHurta]

Nice catch! Thank you for the contribution!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, vprashar2929

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [DavidHurta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vprashar2929]

Nice catch! Thank you for the contribution!

Happy to contribute! 😊

[DavidHurta]

/retitle NO-JIRA: fix(pkg/cincinnati): log the correct root CA pool size

[openshift-ci-robot]

@vprashar2929: This pull request explicitly references no jira issue.

Details

In response to this:

GetUpdates checked TLSClientConfig.ClientCAs to decide whether to log the root CA subject count, but the client transport only ever populates RootCAs (ClientCAs is a server-side field, never set for this outbound client). The nil check was therefore always true: the log always reported "0 root CA subjects" and the branch reporting the real count was dead. Check RootCAs instead, which also correctly guards the RootCAs.Subjects() dereference in the else branch.

Summary by CodeRabbit

• Bug Fixes
• Improved TLS certificate handling when fetching updates.
• Fixed an issue where the app could inspect the wrong certificate pool, which affected root CA logging and could cause errors when no root CA list was set.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[DavidHurta]

/override ci/prow/e2e-hypershift-conformance

[openshift-ci]

@DavidHurta: Overrode contexts on behalf of DavidHurta: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[DavidHurta]

/verified by @DavidHurta

[openshift-ci-robot]

@DavidHurta: This PR has been marked as verified by @DavidHurta.

Details

In response to this:

/verified by @DavidHurta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD bc2e913 and 2 for PR HEAD adfa00a in total

[vprashar2929]

/test e2e-agnostic-ovn-techpreview-serial-2of3

[vprashar2929]

/test e2e-agnostic-ovn-techpreview-serial-2of3

[openshift-ci]

@vprashar2929: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.