NO-ISSUE: Swap kernel-modules-extra dep with recommends

[pacevedom]

/hold

Summary by CodeRabbit

• Bug Fixes
  • Updated package installation requirements so core functionality no longer requires extra kernel modules.
  • Added optional recommendations for standard and real-time kernel networking modules.

[openshift-ci-robot]

@pacevedom: This pull request explicitly references no jira issue.

Details

In response to this:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 88c3be1a-0610-4861-a64f-c8a8c2f88bee

📥 Commits

Reviewing files that changed from the base of the PR and between 089c70a and 08e3a07.

📒 Files selected for processing (1)

• packaging/rpm/microshift.spec

🚧 Files skipped from review as they are similar to previous changes (1)

• packaging/rpm/microshift.spec

---

Walkthrough

The RPM specification removes conditional kernel extra-module requirements from microshift and adds weak recommendations for standard and real-time kernel extra-module packages to microshift-networking.

Changes

RPM dependency scope

Layer / File(s)	Summary
Networking module recommendations packaging/rpm/microshift.spec	microshift no longer requires the kernel extra-module packages. microshift-networking recommends kernel-modules-extra and kernel-rt-modules-extra under the documented conditions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: jogeo, jerpeter1

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change from a kernel-modules-extra dependency to a recommendation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only packaging/rpm/microshift.spec; it adds no Ginkgo tests or test titles, dynamic or otherwise.
Test Structure And Quality	✅ Passed	The pull request changes only packaging/rpm/microshift.spec; it adds no Ginkgo tests or cluster operations to review.
Microshift Test Compatibility	✅ Passed	The pull request changes only packaging/rpm/microshift.spec and adds no Ginkgo e2e tests requiring MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only packaging/rpm/microshift.spec; it adds no Ginkgo e2e tests, so SNO multi-node compatibility checks do not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR changes only packaging/rpm/microshift.spec dependency declarations. It adds no manifests, operator code, controllers, replicas, affinity, topology, node selectors, or tolerations.
Ote Binary Stdout Contract	✅ Passed	The PR changes only packaging/rpm/microshift.spec; no OTE binary or process-level Go code changed, so the stdout contract is not applicable.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only packaging/rpm/microshift.spec; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The PR changes only RPM dependency declarations and comments; the changed lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto implementation, or secret comparison.
Container-Privileges	✅ Passed	The PR changes only packaging/rpm/microshift.spec, not a container or Kubernetes manifest, and adds no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes only RPM dependency declarations and comments; it adds no logging and exposes no passwords, tokens, API keys, PII, session IDs, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[agullon]

/test e2e-aws-tests-cache

[pacevedom]

/test e2e-aws-tests-cache

[openshift-ci]

@pacevedom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-tests-cache	08e3a07	link	true	/test e2e-aws-tests-cache

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.