USHIFT-7364: Revert "Work around ostree permissions error on CentOS 9"

[ggiguash]

This reverts commit 155f943.

Summary by CodeRabbit

• Bug Fixes
  • Removed an outdated CentOS Stream 9 workaround from OSTree container setup.
  • Registry configuration and authentication behavior remain unchanged.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-7364 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This reverts commit 155f943.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ggiguash]

/test ?

[coderabbitai]

Walkthrough

The kickstart template no longer installs an /usr/bin/ostree wrapper that clears INVOCATION_ID. Registry configuration and authentication setup remain unchanged.

Changes

Cohort / File(s)	Summary
Ostree kickstart template test/kickstart-templates/includes/main-ostreecontainer.cfg	Removed the CentOS Stream 9 ostree workaround.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The sole change is a 16-line deletion in a kickstart config; it contains no Ginkgo It(), Describe(), Context(), or When() test title.
Test Structure And Quality	✅ Passed	The commit changes only a Kickstart config and removes a shell workaround; it adds no Ginkgo tests, It blocks, or Eventually/Consistently calls, so this check is not applicable.
Microshift Test Compatibility	✅ Passed	PR is not applicable to this check. It reverts a Kickstart template file and adds no new Ginkgo e2e tests that require MicroShift compatibility verification.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The check applies to new Ginkgo e2e tests. This PR only reverts configuration lines from a Kickstart template file, not Go tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only a test kickstart template file, not deployment manifests, operator code, or controllers. No scheduling constraints or topology-related changes are introduced.
Ote Binary Stdout Contract	✅ Passed	PR modifies only a kickstart template file, not OTE binary or Go process code. Check is not applicable to system provisioning configuration changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only one Kickstart config and deletes 16 workaround lines; it adds no Ginkgo tests or IPv4/external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR contains only deletions. It adds no cryptographic code, weak algorithms, custom crypto, or secret comparisons; the remaining auth and registry setup is unchanged.
Container-Privileges	✅ Passed	The sole change deletes an ostree wrapper from a kickstart template and adds no privileged, host namespace, SYS_ADMIN, allowPrivilegeEscalation, or root setting.
No-Sensitive-Data-In-Logs	✅ Passed	The revert only removes the ostree wrapper. It adds no logging or sensitive-data output; the pull secret remains in auth.json and is removed after installation.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly states that the pull request reverts the CentOS 9 ostree permissions workaround.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ggiguash]

/test e2e-aws-tests-bootc-upstream
/test e2e-aws-tests-bootc-upstream-arm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ggiguash]

/test e2e-aws-tests-bootc-upstream
/test e2e-aws-tests-bootc-upstream-arm

[openshift-ci]

@ggiguash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-tests-bootc-upstream	46c2367	link	true	/test e2e-aws-tests-bootc-upstream

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.