This repository was archived by the owner on Oct 6, 2022. It is now read-only.
Making the Audit Data Source Agnostic - #189
Open
tombuildsstuff wants to merge 13 commits into
Open
Conversation
Contributor
|
Hey @tombuildsstuff it looks like you have a linting issue and one broken test. Any chance of looking into this? If not I can pick it up in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to be merged after #188 since it's rebased on top of it
This PR moves the audit trail out of the etcd calls so it's possible to implement another data source without reimplementing the whole audit system