Consolidate Manifest Handling by Removing KF-Specific Implementation - #470
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the manifest handling implementation in SCORe to consolidate support for a single manifest format, removing the KF-specific implementation in favor of a unified approach. Previously, SCORe provided separate implementations labeled 'icgc' and 'kf' for file download manifests.- #424
Removed the java/bio/overture/score/client/manifest/kf package entirely.
Renamed IcgcManifestService to ManifestServiceImpl.
Eliminated all references of @Profile("!kf") from classes in java/bio/overture/score/client/manifest.
Unified manifest download/upload implementations by refactoring Kf and icgc packages under manifest, creating common implementation classes.