ci: add signed release workflow - #33
Merged
Merged
Conversation
Tagging the repository now builds and signs the app in CI via the shared release workflow, using the ownCloud G2 code-signing material held in the repository secrets. This removes the need to sign a release by hand with 'occ integrity:sign-app' on a machine that holds the private key. The workflow refuses to publish an unsigned artifact: it fails when the signing secrets are absent, and asserts that every tarball contains an appinfo/signature.json whose leaf certificate CN matches the app id. Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
phil-davis
approved these changes
Jul 28, 2026
kw-tmueller
approved these changes
Jul 28, 2026
Member
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a tag-triggered release workflow so releases are built and signed in CI instead of by hand.
Pushing a
v*tag now callsowncloud/reusable-workflows/.github/workflows/release.yml, which:<version>inappinfo/info.xmland aborts if it does not,ocsignfrom a pinned commit and runsmake distwithCAN_SIGN=trueandsign=ocsign ..., so the existingifdef CAN_SIGNblock signs with the G2 material from the repository secrets,appinfo/signature.json(schema v2) whose leaf certificate CN equals the app id — an unsigned build fails rather than publishing quietly,build/dist/external.tar.gzattached.No
Makefilechange is needed.signis a plain=assignment, so the workflow overrides it on the make command line, and the tarball path already matches the workflow's defaultartifact-globofbuild/**/*.tar.gz.SIGNING_KEY,SIGNING_CERTandSIGNING_CHAINare set as repository secrets.dist.ymlis unaffected — it triggers on branch pushes and pull requests, not tags.🤖 Generated with Claude Code