fix(linter): skip suppression validation with --type-check-only#24462
Merged
Conversation
`--type-check-only` skips regular lint rules, leaving an incomplete runtime suppression map. Avoid treating missing rules as stale, and reject suppression update flags that cannot safely operate on partial results. Refs oxc-project#24460
camc314
approved these changes
Jul 13, 2026
camc314
left a comment
camc314
left a comment
Contributor
There was a problem hiding this comment.
please note that bulk supressions are not yet formally released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--type-check-onlymode--suppress-alland--prune-suppressionswhen combined with--type-check-onlyRoot cause
--type-check-onlyintentionally skips regular lint rules, but bulk suppression finalization still compared the full baseline against the partial runtime rule map. A file processed by type checking was marked as seen without regular rule counts, so valid regular suppressions were interpreted as stale.Suppression update operations are also unsafe with this partial result because they could remove or replace entries for rules that did not run.
Validation
just readywith Node.js 24.14.0--type-check-onlyAI usage
I used OpenAI Codex to help investigate, implement, test, and prepare this pull request. I reviewed the changes and take responsibility for the submission.
Fixes #24460