Skip to content

fix(linter/unicorn/prefer-string-raw): skip fix for TSPropertySignature keys#24465

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-prefer-string-raw-ts-property-key
Jul 13, 2026
Merged

fix(linter/unicorn/prefer-string-raw): skip fix for TSPropertySignature keys#24465
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-prefer-string-raw-ts-property-key

Conversation

@camc314

@camc314 camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • prevent unicorn/prefer-string-raw from rewriting TypeScript property signature keys into invalid tagged-template syntax
  • add a regression case based on the PostHog ecosystem CI failure
  • preserve existing behavior for runtime string expressions

Copilot AI review requested due to automatic review settings July 13, 2026 14:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 13, 2026
@camc314 camc314 changed the title fix(linter): skip prefer-string-raw fix for TS property keys fix(linter/unicorn/prefer-string-raw): skip fix for TSPropertySignature keys Jul 13, 2026
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@camc314 camc314 self-assigned this Jul 13, 2026

camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 13, 2:09 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 13, 2:12 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 13, 2:18 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jul 13, 2:20 PM UTC: camc314 added this pull request to the Graphite merge queue.
  • Jul 13, 2:25 PM UTC: Merged by the Graphite merge queue.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93c3cc0a25

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/oxc_linter/src/rules/unicorn/prefer_string_raw.rs
@camc314 camc314 removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing codex/fix-prefer-string-raw-ts-property-key (93c3cc0) with main (e86e0d8)2

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (df67932) during the generation of this report, so e86e0d8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
…ure` keys (#24465)

## Summary

- prevent unicorn/prefer-string-raw from rewriting TypeScript property signature keys into invalid tagged-template syntax
- add a regression case based on the PostHog ecosystem CI failure
- preserve existing behavior for runtime string expressions
@graphite-app graphite-app Bot force-pushed the codex/fix-prefer-string-raw-ts-property-key branch from d4683e2 to dbd08b6 Compare July 13, 2026 14:21
@graphite-app graphite-app Bot merged commit dbd08b6 into main Jul 13, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@graphite-app graphite-app Bot deleted the codex/fix-prefer-string-raw-ts-property-key branch July 13, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants