Skip to content

fix(linter/import/no-duplicates): preserve type modifiers when merging imports#24466

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-duplicates-type-import-merge
Jul 13, 2026
Merged

fix(linter/import/no-duplicates): preserve type modifiers when merging imports#24466
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-duplicates-type-import-merge

Conversation

@camc314

@camc314 camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Copilot AI review requested due to automatic review settings July 13, 2026 14:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 13, 2026
@camc314 camc314 changed the title fix(linter): preserve type modifiers when merging imports fix(linter/import/no-duplicates): preserve type modifiers when merging imports Jul 13, 2026
@camc314 camc314 self-assigned this Jul 13, 2026
@oxc-guard

oxc-guard Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4070654d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/oxc_linter/src/rules/import/no_duplicates.rs Outdated
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing codex/fix-no-duplicates-type-import-merge (be40706) with main (e86e0d8)2

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (df67932) during the generation of this report, so e86e0d8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026

camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

…g imports (#24466)

## Summary

- fix import/no-duplicates when merging a top-level type import with a mixed value/type import
- convert the target to inline type specifiers when required to keep the merged import syntactically valid
- preserve type-only semantics for both import orderings
- add regression coverage based on the Next.js ecosystem CI failure: https://github.com/oxc-project/oxc-ecosystem-ci/actions/runs/29248475854/job/86812762690
@graphite-app graphite-app Bot force-pushed the codex/fix-no-duplicates-type-import-merge branch from d7e7f66 to 261aa39 Compare July 13, 2026 14:31
@graphite-app graphite-app Bot merged commit 261aa39 into main Jul 13, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@graphite-app graphite-app Bot deleted the codex/fix-no-duplicates-type-import-merge branch July 13, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants