Skip to content

fix(linter/import/no-duplicates): avoid duplicate commas when merging imports#24467

Merged
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-duplicates-extra-comma
Jul 13, 2026
Merged

fix(linter/import/no-duplicates): avoid duplicate commas when merging imports#24467
graphite-app[bot] merged 1 commit into
mainfrom
codex/fix-no-duplicates-extra-comma

Conversation

@camc314

@camc314 camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip empty specifier segments created by trailing commas while merging duplicate imports
  • prevent a following import declaration from adding a second comma
  • add a three-import regression that previously produced invalid a,b,,c syntax

Copilot AI review requested due to automatic review settings July 13, 2026 14:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the A-linter Area - Linter label Jul 13, 2026
@codspeed-hq

codspeed-hq Bot commented Jul 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 66 skipped benchmarks1


Comparing codex/fix-no-duplicates-extra-comma (4235a96) with main (5b20828)2

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (261aa39) during the generation of this report, so 5b20828 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@camc314 camc314 changed the title fix(linter): avoid duplicate commas when merging imports fix(linter/import/no-duplicates): avoid duplicate commas when merging imports Jul 13, 2026
@camc314 camc314 self-assigned this Jul 13, 2026
@oxc-guard

oxc-guard Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026

camc314 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

… imports (#24467)

## Summary

- skip empty specifier segments created by trailing commas while merging duplicate imports
- prevent a following import declaration from adding a second comma
- add a three-import regression that previously produced invalid a,b,,c syntax
@graphite-app graphite-app Bot force-pushed the codex/fix-no-duplicates-extra-comma branch from 4235a96 to ac7176d Compare July 13, 2026 15:06
@graphite-app graphite-app Bot merged commit ac7176d into main Jul 13, 2026
29 checks passed
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Jul 13, 2026
@graphite-app graphite-app Bot deleted the codex/fix-no-duplicates-extra-comma branch July 13, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants