Skip to content

Upgrade to .NET Core 3.1 (#1488) - #1489

Merged
Jonarw merged 1 commit into
oxyplot:developfrom
Jonarw:update-target-platforms
Mar 18, 2020
Merged

Upgrade to .NET Core 3.1 (#1488)#1489
Jonarw merged 1 commit into
oxyplot:developfrom
Jonarw:update-target-platforms

Conversation

@Jonarw

@Jonarw Jonarw commented Mar 3, 2020

Copy link
Copy Markdown
Member

Fixes #1488.
Also fixes #1483.

Checklist

  • I have included examples or tests
  • I have updated the change log
  • I am listed in the CONTRIBUTORS file
  • I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:

  • Update all netcoreapp3.0 targets to netcoreapp3.1
  • Change target order so net4xx targets are listed before netcoreapp3.x targets

Did I miss anything?

@oxyplot/admins

@Jonarw

Jonarw commented Mar 3, 2020

Copy link
Copy Markdown
Member Author

Azure Pipelines Build seems to fail for some reason... I don't really know what to do about this. @objorke could you take a look? Thanks!

@objorke

objorke commented Mar 3, 2020

Copy link
Copy Markdown
Member

@Jonarw

Jonarw commented Mar 9, 2020

Copy link
Copy Markdown
Member Author

Is it actually a failed unit test? Yes, there is an exception thrown during testing, but no test is reported as failed... On my machine all test pass (except ExportPngAndCompareWithBaseline, but I guess that one is tricky anyway and does actually pass on Azure).

I don't really know what to do about this. Can we just ignore this error?

@Jonarw

Jonarw commented Mar 18, 2020

Copy link
Copy Markdown
Member Author

I am going to go ahead and merge this, considering that the AppVeyor build works fine.

@Jonarw
Jonarw merged commit aee6661 into oxyplot:develop Mar 18, 2020
@Jonarw
Jonarw deleted the update-target-platforms branch October 12, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to netcoreapp3.1 Change order of TargetFrameworks in OxyPlot.Wpf.csproj

2 participants