Skip to content

When creating a ParseUser instance, be sure to use static to get registered subclasses.#394

Merged
acinader merged 1 commit into
parse-community:masterfrom
acinader:fix-subclassed-user-facebook
Apr 25, 2018
Merged

When creating a ParseUser instance, be sure to use static to get registered subclasses.#394
acinader merged 1 commit into
parse-community:masterfrom
acinader:fix-subclassed-user-facebook

Conversation

@acinader

Copy link
Copy Markdown
Contributor

see: #84

This just eliminates two other places where ParseUser is called instead of using the subclass's static constructor.

@acinader

Copy link
Copy Markdown
Contributor Author

@montymxb, unfortunately, unit tests are failing on master due to an npm install issue.....

@montymxb

Copy link
Copy Markdown
Contributor

Gotcha, I'll look into that today. Other than the CI issue the changes look good 👍 , thanks for catching those. I'll see if I can resolve the CI thing before we take this in.

@acinader

Copy link
Copy Markdown
Contributor Author

@montymxb do you want me to merge this?

@montymxb

Copy link
Copy Markdown
Contributor

@acinader Yeah that's fine. Still need to resolve the CI issue, but we can do that separately.

@acinader
acinader merged commit 58e4cb0 into parse-community:master Apr 25, 2018
@acinader
acinader deleted the fix-subclassed-user-facebook branch April 25, 2018 17:45
@acinader
acinader restored the fix-subclassed-user-facebook branch August 25, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants