Add PHP 8 support#52
Merged
wachterjohannes merged 4 commits intoFeb 12, 2021
Merged
Conversation
alexander-schranz
force-pushed
the
feature/php-8-compatibility
branch
5 times, most recently
from
February 11, 2021 19:30
0b16047 to
12b4b5b
Compare
alexander-schranz
force-pushed
the
feature/php-8-compatibility
branch
from
February 11, 2021 19:31
12b4b5b to
5d85483
Compare
alexander-schranz
force-pushed
the
feature/php-8-compatibility
branch
from
February 12, 2021 09:29
b6e2c3c to
ec8d64a
Compare
alexander-schranz
force-pushed
the
feature/php-8-compatibility
branch
6 times, most recently
from
February 12, 2021 10:01
c1adc53 to
813d162
Compare
alexander-schranz
force-pushed
the
feature/php-8-compatibility
branch
from
February 12, 2021 10:05
813d162 to
e43c616
Compare
| * @param Event|LegacyEvent $event | ||
| */ | ||
| public function run(Event $event) | ||
| public function run($event) |
Member
Author
There was a problem hiding this comment.
Not sure how this did ever work with symfony 5 /cc @wachterjohannes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Run: https://github.com/alexander-schranz/TaskBundle/pull/1/checks