Skip to content
This repository was archived by the owner on Mar 6, 2022. It is now read-only.

register ProgressNotifier service - #23

Merged
dantleech merged 1 commit into
phpactor:masterfrom
camilledejoye:handle-progress-notification
Sep 19, 2021
Merged

register ProgressNotifier service#23
dantleech merged 1 commit into
phpactor:masterfrom
camilledejoye:handle-progress-notification

Conversation

@camilledejoye

Copy link
Copy Markdown
Contributor

Depends on phpactor/language-server#36

It registers a new ProgressNotifier service which is responsible to send progress to the client using window/showMessage or $/progress depending on the client capabilities.

@dantleech

Copy link
Copy Markdown
Contributor

Phpstan is failing, you could add a simple test to ensure that the service can be retrieved: https://github.com/phpactor/language-server-extension/blob/master/tests/LanguageServer/Unit/LanguageServerExtensionTest.php

@dantleech
dantleech merged commit 087c55c into phpactor:master Sep 19, 2021
@dantleech

Copy link
Copy Markdown
Contributor

I'll fix it :)

@camilledejoye

Copy link
Copy Markdown
Contributor Author

I think phpstan was failing because the dependency was not updated yet.
I didn't even thought of looking for a test, it's just simple configuration for me to setup a container.

@camilledejoye
camilledejoye deleted the handle-progress-notification branch September 19, 2021 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants