Error: Bad Request

[balachandra]

Hi Guys,

im seeing the below error while using the static middleware on express. if i comment the static middleware app works fine. any clue on whats going on

app.use(express.static(__dirname));

Thank you,
-bala

error trace:

Error: Bad Request
    at SendStream.error (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/send/lib/send.js:145:16)
    at SendStream.pipe (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/send/lib/send.js:298:31)
    at Object.staticMiddleware [as handle] (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/static.js:84:8)
    at next (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/proto.js:190:15)
    at multipart (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/multipart.js:64:37)
    at /Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:57:9
    at urlencoded (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/urlencoded.js:51:37)
    at /Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:55:7
    at json (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/json.js:53:37)
    at Object.bodyParser [as handle] (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/bodyParser.js:53:5)
    at next (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/proto.js:190:15)
    at Object.expressInit [as handle] (/Users/balachandra/Desktop/thply/node_modules/express/lib/middleware.js:30:5)
    at next (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/proto.js:190:15)
    at Object.query [as handle] (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/middleware/query.js:44:5)
    at next (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/proto.js:190:15)
    at Function.app.handle (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/proto.js:198:3)
    at Server.app (/Users/balachandra/Desktop/thply/node_modules/express/node_modules/connect/lib/connect.js:65:37)
    at Server.EventEmitter.emit (events.js:98:17)
    at HTTPParser.parser.onIncoming (http.js:2045:12)
    at HTTPParser.parserOnHeadersComplete [as onHeadersComplete] (http.js:119:23)
    at Socket.socket.ondata (http.js:1935:22)
    at TCP.onread (net.js:524:27)

[tillberg]

I ran into the same issue (or at least the same error) when trying to GET resources with unicode escape sequences in them.

This workaround below converts the escape sequences (not sure my terminology is correct, but something like this: La%20Bohe%u0300me - particularly the e%u0300) into the actual characters (e.g. La Bohème) before passing them on to express / send:

var serveFn = express.static(path);
app.use('/mypath', function (req, res) {
    req.url = unescape(req.url);
    return serveFn.apply(this, arguments);
});

[dougwilson]

@balachandra I'm closing this for now, but if you can provide more details I can look into it. I'm looking to be able to do something where I can reproduce it at the very least.

[161chihuahuas]

i can confirm this as well, and my workaround is the same as @tillberg - seems like send should handle this. @dougwilson what sort of further details do you need to reproduce this? i reproduced consistently by sending escaped unicode characters in the url just like the example above. i'd be happy to send a PR, if you would agree that send should be responsible for handling this gracefully.

[dougwilson]

%u0300 is not a valid URL escape sequence AFAIK. Can you point me to the RFC for this sequence?

[dougwilson]

To be clear, what I'm saying is that unless you can point me to a RFC that says otherwise, La%20Bohe%u0300me is not a valid URL sequence. The valid sequence for that would be La%20Bohe%CC%80me

[161chihuahuas]

Ah! Indeed, it seems that send is in fact handling this as I would expect, as this is a "bad request". Thanks for the clarification.