fix: omit leading newline when formatting StackTrace with %+v#250
Closed
Solaris-star wants to merge 1 commit into
Closed
fix: omit leading newline when formatting StackTrace with %+v#250Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
|
This is intended behavior. |
Author
|
Closing this based on maintainer feedback that the leading newline is intended behavior. Thanks for taking a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fmt.Sprintf("%+v", stackTrace)prefixed every frame with a newline, including the first one. That made a bare StackTrace print with a leading blank line (#230).Fix
In
StackTrace.Formatfor%+v, write a newline only between frames (not before the first). Error formatting is unchanged becausestack.Formatstill prefixes each frame with\nafter the message.Test plan
go test -vet=off .TestStackTraceFormatexpectationTestStackTraceFormatNoLeadingNewlineFixes #230