#120 Add layout slider - #232
Merged
Merged
Conversation
amakhno
force-pushed
the
add-layout-slider
branch
2 times, most recently
from
November 13, 2021 19:44
007d340 to
b82f0bb
Compare
amakhno
force-pushed
the
add-layout-slider
branch
from
November 14, 2021 21:57
b82f0bb to
bd3aeb5
Compare
amakhno
force-pushed
the
add-layout-slider
branch
from
November 15, 2021 20:29
bd3aeb5 to
4191578
Compare
amakhno
marked this pull request as ready for review
November 15, 2021 20:32
Contributor
Author
|
Had to change the The True used to be serialized as "visible": "true", not "visible": true Now it's working |
Collaborator
|
This is a 100% godlike PR, can't hope for more <3 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm still working on it, but it was possible to reproduce a part of the Plotly example
Note: I've probably found a bug in
StyleParam.Visible.toString. It isn't passed to the JSON correctly. True value is "visible":"true", False is "visible": "false", but they shouldn't be strings. Still researching, but a quick fix helped