Skip to content

First pass at Windows CI testing. - #1127

Merged
shammamah-zz merged 3 commits into
devfrom
windows-circleci
Feb 27, 2020
Merged

First pass at Windows CI testing.#1127
shammamah-zz merged 3 commits into
devfrom
windows-circleci

Conversation

@shammamah-zz

@shammamah-zz shammamah-zz commented Feb 20, 2020

Copy link
Copy Markdown
Contributor

About

Closes https://github.com/plotly/dash-core/issues/91

Needs plotly/dash-core-components#761 to be merged so that the --branch parameter can be removed from the line in which we clone dash-core-components.

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • task 1
    • task 2
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follow
    • this github #PR number updates the dash docs
    • here is the show and tell thread in plotly dash community

@Marc-Andre-Rivet Marc-Andre-Rivet added this to the Dash v1.10 milestone Feb 27, 2020

@Marc-Andre-Rivet Marc-Andre-Rivet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💃

@shammamah-zz
shammamah-zz merged commit ba8abf6 into dev Feb 27, 2020
@shammamah-zz
shammamah-zz deleted the windows-circleci branch February 27, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants