Log-scale layout of heatmap bricks for log-scale axes (fixes #5991) - #6819
Conversation
|
Bumping this @archmoj after the winter holiday. I'm hoping to get this into a near-term release for my team. |
|
@archmoj Can you let me know anything that needs to happen to get this merged? |
|
Thanks for the fix. 🥇 |
|
@archmoj after my two comments above this looks good. Thanks @andrew-matteson! There's still an issue with |
|
@alexcjohnson I think my fixes cover your cases. LMK if you have further thoughts. |
|
There is a webgl-jasmine failure that I don't think is related to the recent changes. If it is, could you let me know what's going on? I can't quite deduce from the error messages. |
|
@alexcjohnson I got the tests to rerun and they passed. LMK if this needs anything else. |
This reverts commit 2b471c3.
|
@archmoj @alexcjohnson I'd love to get this in for an upcoming release my team has. Is there anything I need to do to wrap this up? |
|
Thanks very much for the fix. |
|
Thank you! I appreciate this product so much :-) |
This fixes the heatmap brick layout identified in #5991 . The logic of
make_bounds_arrayis extended with logic that replicates the linear scale logic in log space.This PR fixes two problems in my use of the library:
I've added a mock and baseline that behave correctly.