chore: Update geo trace fitbounds default to 'locations'#7895
chore: Update geo trace fitbounds default to 'locations'#7895camdecoster wants to merge 18 commits into
Conversation
There was a problem hiding this comment.
This test seems somewhat less useful now. Might be worth setting fitbounds: false on this one.
There was a problem hiding this comment.
This test still functions perfectly fine (i.e. if something goes wrong with tick0 for geo plots it will fail), but it might be worth setting a lower zoom level to make it more human-obvious what's going on here. Not a blocker.
There was a problem hiding this comment.
Do you know why the new image renders a smaller plot? Not a dealbreaker, but the previous version seems better.
There was a problem hiding this comment.
How does fitbounds choose a center when the geoJSON wraps all the way around the globe?
There was a problem hiding this comment.
The top plot doesn't look right, why is the orange line forced to wrap off the right edge?
There was a problem hiding this comment.
Green dotted line is cut off the top. Maybe this is an existing limitation with fitbounds, if so, it's not the end of the world but let's open an issue.
There was a problem hiding this comment.
It seems not ideal to show less of the southern latitudes when there's no more of the northern latitudes to be shown, would it be possible to add a constraint that the north edge of the map can't be lower than the top of the plot area in the initial render?
There was a problem hiding this comment.
Again not totally clear to me how this centerpoint was chosen.
I mean, there's no reason the center has to be the Europe-centric map we're used to, although that does have the advantage of splitting fewer countries in half.
There was a problem hiding this comment.
Same comment here re: centerpoint
There was a problem hiding this comment.
Probably another one worth editing the mock to set fitbounds: false
There was a problem hiding this comment.
What happened here? This seems wrong
Description
Updates the
fitboundsdefault value to"locations"for geo traces. Also fixes (previously unknown) bug related to using zoom buttons withfitboundsactive.Closes #7885
Changes
fitboundsincompatible projections (craig/satellite/albers-usa)Videos
Before (
fitbounds: false, default)Screencast.From.2026-07-09.15-30-04.mp4
Before (
fitbounds: "locations")Screencast.From.2026-07-09.16-51-23.mp4
After (
fitbounds: "locations", default)Screencast.From.2026-07-09.15-29-05.mp4
Testing
geo_orthographicNotes
fitboundsused to default tofalse. This changes the default to"locations".falsetofitboundsfitboundswas active