Skip to content

Update plotly.js to v4.0.0-rc.0 - #5673

Merged
emilykl merged 12 commits into
v7.0from
update-plotlyjs-v4.0.0-rc.0
Jul 27, 2026
Merged

Update plotly.js to v4.0.0-rc.0#5673
emilykl merged 12 commits into
v7.0from
update-plotlyjs-v4.0.0-rc.0

Conversation

@emilykl

@emilykl emilykl commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Description of change

  • Update plotly.js to v4.0.0-rc.0
  • Run codegen and regenerate Jupyter js bundles
  • Remove all references to mapbox in Plotly Express
  • Update tests to remove mapbox references

Note: The failing plotly.js dev build CI job can be ignored. That job runs the tests after pulling dist/plotly.js from the plotly.js master branch, so naturally it will fail since the plotly.js v4.0 changes are not yet on master.

The failing docs build can also be ignored; it will fail until the docs are updated to remove mapbox code, which will be in a separate PR.

Notes

Closes #4824 due to the color library update in plotly.js v4.0.0.

@emilykl
emilykl force-pushed the update-plotlyjs-v4.0.0-rc.0 branch from e9e1d18 to d3c2587 Compare July 23, 2026 16:08
@emilykl
emilykl requested a review from camdecoster July 23, 2026 16:28

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could we update the docs separately to keep things tidy?
  • I think we can remove the Stream deprecation warning in _deprecations.py
  • I still see a lot of references to linkText/link_text and showLink/show_link. Could those be removed?
  • ColorValidator will need to be updated per the v4 changes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ColorValidator will need to be updated to remove the references and regex checks for hsv since that got removed. The regex patterns will also need to be updated to match the new color specifier support.

@emilykl

emilykl commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author
  • Could we update the docs separately to keep things tidy?

Yes, as long as you're OK with the docs build failing on this PR. I'll split the docs changes into a separate PR.

  • I think we can remove the Stream deprecation warning in _deprecations.py
  • I still see a lot of references to linkText/link_text and showLink/show_link. Could those be removed?
  • ColorValidator will need to be updated per the v4 changes

👍 will do, thanks

@emilykl
emilykl force-pushed the update-plotlyjs-v4.0.0-rc.0 branch from cb56252 to 3a76e7d Compare July 23, 2026 20:48
@emilykl
emilykl force-pushed the update-plotlyjs-v4.0.0-rc.0 branch from 141a7a8 to 49f3825 Compare July 24, 2026 17:29
@@ -28,26 +28,58 @@ def validator_aok_colorscale():
)


VALID_COLORS = [

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camdecoster I tried to be pretty comprehensive here, but please suggest any formats I've missed. Likewise for the invalid colors list.

@emilykl
emilykl requested a review from camdecoster July 24, 2026 17:37

@camdecoster camdecoster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emilykl
emilykl merged commit baf6d33 into v7.0 Jul 27, 2026
26 of 37 checks passed
@emilykl
emilykl deleted the update-plotlyjs-v4.0.0-rc.0 branch July 27, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants