Drop support for Kaleido v0.x, and Orca - #5677
Merged
Merged
Conversation
emilykl
force-pushed
the
drop-kaleido-v0
branch
2 times, most recently
from
July 28, 2026 01:15
0cfbbf4 to
6684995
Compare
emilykl
marked this pull request as ready for review
July 28, 2026 13:06
camdecoster
reviewed
Jul 28, 2026
camdecoster
left a comment
Contributor
There was a problem hiding this comment.
This looks good overall, but I have a few suggestions. Could you take a look at _sg_scraper.py? I think that might need to be updated since the Orca option with Sphinx Gallery was removed.
Comment on lines
+3770
to
+3772
| fig: | ||
| Figure object or dict representing a figure | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| fig: | |
| Figure object or dict representing a figure |
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
camdecoster
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5623, closes #5371
Description of change
engineargument from image IO functionsNote:
plotly.js dev buildCI job is expected to fail, and docs build will fail until docs are updated by #5678.Testing strategy
test_kaleido_v0_error.pywhich verifies that the expected error is raised when image IO functions are called with Kaleido v0.x installedTo test locally:
fig.write_image(px.scatter(y=[1,2,3]), "fig.png")works as expected and produces an imagepip install "kaleido<1"fig.write_image(px.scatter(y=[1,2,3]), "fig.png")raises aRuntimeErrorsaying that only Kaleido version 1 and greater is supportedGuidelines