Add codegen check CI job - #5681
Merged
Merged
Conversation
Closed
emilykl
force-pushed
the
add-ci-codegen-check
branch
from
July 28, 2026 17:09
73d4a6d to
c30b679
Compare
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to ensure Plotly’s Python code-generated artifacts remain in sync with what’s committed, and introduces a focused dependency extra to run codegen in CI.
Changes:
- Add a new CI workflow that runs
python commands.py codegenand fails if it produces any repo diffs. - Introduce a
dev_codegenextra inpyproject.tomlto install only codegen-required dependencies (and wire it intodev_optional). - Update
uv.lockto reflect the new extra and dependency graph.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
uv.lock |
Adds/updates the locked dependency set to include the new dev-codegen extra. |
pyproject.toml |
Defines the dev_codegen extra (and updates dev_optional to include it). |
.github/workflows/check-codegen.yml |
New workflow to run codegen and fail CI when generated files don’t match committed files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
camdecoster
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue
Closes #5680
Description of change
Adds a CI job which runs the Python codegen script and fails if the generated files do not match what's committed in the repo.
Also adds a
[dev_codegen]extra inpyproject.tomlwhich installs only the packages needed to run the codegen. This is used in the CI job.uv.lockis also updated accordingly.This will ensure that the generated Python files (
python/graph_objs/) are always up-to-date.Testing
The job fails on this PR because the codgen files are currently out of date on
v7.0.See #5682 for a demo of the job passing and failing.
Guidelines