[fix] exec_command(get_process=True) does not respect encoding#56
Merged
dmitry-lipetsk merged 1 commit intoJun 30, 2026
Conversation
We does not use "text" (it is another question) and lool at encoding only. As result, when get_result is True we have to calculate a right value of 'text' argument and pass it to subprocess.Popen to return a right stdout and stderr in a result object.
dmitry-lipetsk
deleted the
20260630_009--exec_command-get_process-and-encoding
branch
June 30, 2026 19:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We does not use "text" (it is another question) and look at encoding only.
As result, when get_result is True we have to calculate a right value of 'text' argument and pass it to subprocess.Popen to return a right stdout and stderr in a result object.