Skip to content

fix: (typo) PostgresNodeUtils.detect_port_conflict #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Jul 17, 2026
Merged

fix: (typo) PostgresNodeUtils.detect_port_conflict #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,7 @@ def LOCAL__raise_cannot_start_node__std(from_exception):
if nAttempt == __class__._C_MAX_START_ATEMPTS:
self._raise_cannot_start_node(e, "Cannot start node after multiple attempts.")

is_it_port_conflict = PostgresNodeUtils.delect_port_conflict(log_reader)
is_it_port_conflict = PostgresNodeUtils.detect_port_conflict(log_reader)

if not is_it_port_conflict:
LOCAL__raise_cannot_start_node__std(e)
Expand Down Expand Up @@ -2598,7 +2598,7 @@ def _collect_logs(self) -> typing.Dict[str, LogInfo]:

class PostgresNodeUtils:
@staticmethod
def delect_port_conflict(log_reader: PostgresNodeLogReader) -> bool:
def detect_port_conflict(log_reader: PostgresNodeLogReader) -> bool:
assert type(log_reader) is PostgresNodeLogReader

blocks = log_reader.read()
Expand Down
2 changes: 1 addition & 1 deletion tests/test_testgres_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1630,7 +1630,7 @@ def impl__test_pg_ctl_wait_option(

nAttempt = 0
while True:
if PostgresNodeUtils.delect_port_conflict(node_log_reader):
if PostgresNodeUtils.detect_port_conflict(node_log_reader):
logging.info("Node port {} conflicted with another PostgreSQL instance.".format(
node.port
))
Expand Down