Skip to content

install via git for language: node#3719

Merged
asottile merged 1 commit into
mainfrom
npm-unknown-options
Jul 15, 2026
Merged

install via git for language: node#3719
asottile merged 1 commit into
mainfrom
npm-unknown-options

Conversation

@asottile

@asottile asottile commented Jul 15, 2026

Copy link
Copy Markdown
Member

this avoids trying to play catch-up with whatever preparation commands npm does when installing from npm i git+... (which differs from npm i a/dir) the latter does not run any preparation commands leading to broken installs

the previous command we were using was suggested by the npm devs, however some of the options that it was using are no longer part of npm itself and npm 12.x errors on unknown options

this ~technically breaks compatibility on windows some 2019-era npm versions but it's big 26 so...

resolves #3517

this avoids trying to play catch-up with whatever preparation commands npm
does when installing from `npm i git+...` (which differs from `npm i a/dir`)
the latter does not run any preparation commands leading to broken installs

the previous command we were using was suggested by the npm devs, however some
of the options that it was using are no longer part of npm itself and npm 12.x
errors on unknown options
@asottile
asottile marked this pull request as ready for review July 15, 2026 20:31
@asottile
asottile enabled auto-merge July 15, 2026 20:32
@asottile
asottile merged commit b2b9119 into main Jul 15, 2026
28 checks passed
@asottile
asottile deleted the npm-unknown-options branch July 15, 2026 20:38
@yxtay

yxtay commented Jul 17, 2026

Copy link
Copy Markdown

Will there be a release soon containing this fix?

@asottile

Copy link
Copy Markdown
Member Author

I plan to never release this! hahaha

@pre-commit pre-commit deleted a comment from hollow Jul 20, 2026
@iTrooz

iTrooz commented Jul 21, 2026

Copy link
Copy Markdown

You can do pipx install git+https://github.com/pre-commit/pre-commit in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Remove usage of deprecated npm install option --ignore-prepublish

3 participants