Skip to content

Removed note about aria-label requiring a <button> or <a> element#168

Merged
mdo merged 1 commit into
primer:masterfrom
jdan:aria-label
Feb 16, 2016
Merged

Removed note about aria-label requiring a <button> or <a> element#168
mdo merged 1 commit into
primer:masterfrom
jdan:aria-label

Conversation

@jdan

@jdan jdan commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

aria-label can be used on any element, and is even used on the <span> example right below this paragraph.

I verified with ChromeVox+Chrome and VoiceOver+Safari that the tooltip's contents (via aria-label) are read off even on a <span>.

`aria-label` can be used on any element, and is even used on the `<span>`
example right below this paragraph.

I verified this with ChromeVox+Chrome and VoiceOver+Safari.
@mdo

mdo commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

Forgot to mention in the other PR, but yeah this maps to our experience with this stuff on github/github—basically we do the same and wrap elements in <span>s when we need to.

@mdo mdo added the docs label Feb 3, 2016
@mdo mdo added this to the v2.6.0 milestone Feb 16, 2016
mdo added a commit that referenced this pull request Feb 16, 2016
Removed note about `aria-label` requiring a <button> or <a> element
@mdo mdo merged commit 6243976 into primer:master Feb 16, 2016
@jdan

jdan commented Feb 17, 2016

Copy link
Copy Markdown
Contributor Author

Thank ya 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants