Fail dist build when for postcss warnings#2180
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ca2d3ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jonrohan
approved these changes
Jul 29, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
We would like to detect postcss warnings at build time, and prevent them from being merged/published
What approach did you choose and why?
Throw an error when a warning is detected during postcss build. Sample output from a few commits back:
@dgreif ➜ /workspaces/css (37deef3a ✗) $ script/dist.js autoprefixer: /workspaces/css/src/layout/index.scss#sass:586:2: start value has mixed support, consider using flex-start instead Error: Warnings while compiling src/layout/index.scss. See output above. at file:///workspaces/css/script/dist.js:60:15 at async Promise.all (index 17) at async dist (file:///workspaces/css/script/dist.js:72:5) autoprefixer: /workspaces/css/src/core/index.scss#sass:1:0: start value has mixed support, consider using flex-start instead autoprefixer: /workspaces/css/src/index.scss#sass:10455:2: start value has mixed support, consider using flex-start insteadThis will cause
script/dist.jsto exit with code1What should reviewers focus on?
Is failing the build for warnings the right approach?
Can these changes ship as is?