test: make evals judge outcomes and self-explain failures - #241
Open
angeloashmore wants to merge 3 commits into
Open
test: make evals judge outcomes and self-explain failures#241angeloashmore wants to merge 3 commits into
angeloashmore wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Two evals scored 0/3 in the first CI run for reasons that were not agent failures. "adds constrained fields" required the
field add content-relationshipcommand, but the agent usedfield add link --allow document, which models the same constrained relationship; the eval now asserts the resulting model shape instead of the command. "commits and pushes local model changes" seeded an article type with no fields, so the agent reasonably asked for confirmation instead of publishing an empty type; the fixture now seeds a title field.toHaveRunfailures now also print the agent's final message, which is how the empty-type problem was found. Future CI failures explain themselves in the log without a local rerun.Checklist
Preview
How to QA 1
🤖 Generated with Claude Code
Note
Low Risk
Test-only changes to eval assertions and fixtures; no production runtime behavior.
Overview
Evals now grade agent results by outcome instead of exact CLI spelling, so CI failures reflect real regressions rather than equivalent command choices.
In adds constrained fields, the test no longer requires
field add content-relationshiporfield add link; it only checks that somefield addran and that the product model has the select options and a document link constrained toauthor(includingselect: "document").In commits and pushes local model changes, the article fixture includes a Title text field so the agent is not stuck confirming an empty type before
push.When
toHaveRunfails, the assertion message now includes the agent’s final message alongside the command list, making CI logs easier to debug without a local rerun.Reviewed by Cursor Bugbot for commit 7f8c2d4. Bugbot is set up for automated code reviews on this repo. Configure here.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩