Resolves: #[1417] Value Now Compares to missingFloat Variable#1441
Merged
Conversation
ericahin
force-pushed
the
compare-to-missingFloat-issue
branch
from
February 25, 2026 19:23
02b8ddf to
9ed1143
Compare
ericahin
force-pushed
the
compare-to-missingFloat-issue
branch
from
March 9, 2026 18:10
dcbca46 to
0a6d561
Compare
ericahin
force-pushed
the
compare-to-missingFloat-issue
branch
from
March 9, 2026 18:11
0a6d561 to
1c8a1da
Compare
ericahin
marked this pull request as ready for review
March 9, 2026 18:12
|
@elisefergusonn can you please review |
|
LGTM 👍 |
Contributor
|
Looks good to me too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Title: clear and descriptive
✅ Resolves: Resolves #1417
✅ Changes: Changed the comparison on line 4822 that is checking if the float variable "value" is NaN to use the globally declared variable "missingFloat." This was labeled as a TODO. This maintains consistency throughout the document so is anything were to change, this comparison would stay consistent with the rest of the file.
✅ Tests: I created a function in TableTest.java called testGetMaxFloat() which checks all edge cases of Null, negative numbers, 0, positive numbers, etc. I also tested using the "./gradlew test" command, all tests were passed by this code
✅ Checklist: All tests pass and I have pulled/pushed the most recent changes/updates from upstream onto my branch