Re-vendor the carried hub files to the current canonical - #298
Merged
Conversation
These files are carried verbatim from ptr727/ProjectTemplate, so a local copy that differs is drift rather than a choice. The hub's regenerated fleet divergence report lists this repo for them. Changed: .markdownlint-cli2.jsonc repo-config/configure.sh Line endings preserved as each file held them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-vendors two carried “hub” files from ptr727/ProjectTemplate to eliminate drift, keeping this repository aligned with the fleet’s canonical configuration and linting behavior.
Changes:
- Update
repo-config/configure.shto the newerapply/checkcommand design, adding read-only drift validation. - Update
.markdownlint-cli2.jsoncto enable MD033 with an allowlist fordetails/summary.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| repo-config/configure.sh | Replaces the older apply-only script with an apply/check workflow and adds drift-check logic for settings, rulesets, and security features. |
| .markdownlint-cli2.jsonc | Adjusts markdownlint configuration to allow details/summary while keeping inline-HTML linting enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.markdownlint-cli2.jsoncandrepo-config/configure.share carriedverbatimfrom ptr727/ProjectTemplate, so a copy that differs is drift rather than a choice. The hub's regenerated fleet divergence report lists this repo for both..markdownlint-cli2.jsonccarries a behavior change: the canonical enablesMD033withdetailsandsummaryallowed. Verified rather than assumed:markdownlint-cli2over**/*.mdreports 0 issues here under the restored config.repo-config/configure.shadvances to the currentapply/checkdesign. This copy was the older apply-only one.Line endings preserved.
Not in this PR, deliberately: this repo also carries
dotnet_analyzer_diagnostic.severity = suggestionin.editorconfig, which ptr727/ProjectTemplate#353 measured at 24xUnit1051sites here. Removing it turns real analyzers back on, and the measurement behind that number is two weeks old, so it gets its own pull request with a real build rather than riding along with a config copy.Part of the fleet re-vendor sweep tracked in the hub's
TODO.md.